这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@getzze
Copy link
Contributor

@getzze getzze commented May 29, 2025

See Diaoul/subliminal#1302

This PR fixes an unintended side-effect, that importing knowit changes the behavior of the pyyaml module.
It's not clear why the original code was provoking this side-effect, though.

@getzze
Copy link
Contributor Author

getzze commented Jun 11, 2025

@ratoaq2 Any idea when you are going to have time to look at the PR?
Without it, users have very negative side-effect when importing knowit (or subliminal that has it as a dependency) and decoding Yaml files.

@ratoaq2 ratoaq2 merged commit ce96783 into ratoaq2:main Jul 26, 2025
0 of 4 checks passed
@ratoaq2
Copy link
Owner

ratoaq2 commented Jul 26, 2025

thanks

@vivodi
Copy link

vivodi commented Jul 28, 2025

You should have released a new version after merging this PR before dropping support for Python 3.9 and 3.10. Now, Python 3.9 and 3.10 users are stuck with knowit 0.5.6, which still contains this bug.

Would you @ratoaq2 be able to release a patched version, knowit 0.5.6.1, that includes this fix for Python 3.9 and 3.10?

@ratoaq2
Copy link
Owner

ratoaq2 commented Jul 28, 2025

Easier to restore 3.9 and 3.10 compatibility 4dd92a9

btw, 3.9 is less than 3 months away from EOL

@vivodi
Copy link

vivodi commented Jul 28, 2025

Easier to restore 3.9 and 3.10 compatibility 4dd92a9

btw, 3.9 is less than 3 months away from EOL

Thanks! Our project removed support for Python 3.9 earlier this month.

I just feel that the last version of knowit to support Python 3.9 shouldn't contain such a serious bug, especially since Python 3.9 hasn't reached its EOL yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants