这是indexloc提供的服务,不要输入任何密码
Skip to content

Better group labels, dialog fix #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Acumane
Copy link

@Acumane Acumane commented May 10, 2025

Firefox's group labels look pretty awful. Now they're more appealing:


Colors were omitted and margins may need to be adjusted... my font scale is different so YMMV.

Also dialogs weren't using --gnome-window-color. btw this variable hasn't reflected my GTK theme since v121.1 so I've been setting it to --gnome-[toolbar|entry]-color since.

tab-group:not([collapsed]) &::before {
background-image: var(--gnome-icon-pan-down-symbolic);
}
}

&[aria-label="Unnamed Group"] {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use [tooltiptext=""], otherwise it will only work when the browser is set to English.

Copy link
Owner

@rafaelmardojai rafaelmardojai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could you separate the change in two commits? One for the group label and other for the dialogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants