这是indexloc提供的服务，不要输入任何密码
Skip to content

add sidebar.revamp.round-content-area support #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add sidebar.revamp.round-content-area support #974

wants to merge 9 commits into from

Conversation

M0on9
Copy link

@M0on9 M0on9 commented Apr 27, 2025

Moves the border from the toolbox and sidebar to tabbox.
Adds #947 (sorry for the multiple references, i promise this is the last)

rafaelmardojai
rafaelmardojai requested changes Apr 27, 2025
View reviewed changes
theme/parts/toolbox.css
@@ -14,7 +14,6 @@
/* Toolbox colors */
#navigator-toolbox {
background: var(--gnome-toolbar-background) !important;
border-bottom: 1px solid var(--gnome-toolbar-border-color) !important;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't break the separation between sidebar and toolbars? I would appreciate some screenshots on how does the change looks until I can test it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how it looks with sidebar.revamp.round-content-area disabled?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

@M0on9
Copy link
Author

M0on9 commented Apr 27, 2025

uh oh
image
turns out the border-top/border-left instead of border breaks the corner when a site is loaded and I just didn't catch it until i opened a site with the same sidebar color.
maybe i keep border: 1px solid rgba(0,0,0,0.9); and set border-bottom/border-right to 0% opacity? I just noticed the border goes around the whole tabbox and don't want that if it wasn't there before.

@M0on9 M0on9 marked this pull request as draft April 27, 2025 21:53
@M0on9
Copy link
Author

M0on9 commented Apr 27, 2025

#974 (comment)

Only happening on that site, ignoring for now as a site-specific glitch.
What im more concerned with is the right border being missing when you turn on sidebar on the right

@M0on9 M0on9 marked this pull request as ready for review April 27, 2025 22:25
@M0on9 M0on9 requested a review from rafaelmardojai April 27, 2025 22:25
@janvhs
Copy link

janvhs commented Jul 24, 2025 •
edited
Loading

Hi, any chance this gets merged? I really like the vertical tabs and this PR would make the integration look really nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelmardojai rafaelmardojai Awaiting requested review from rafaelmardojai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M0on9 @janvhs @rafaelmardojai