print more Error types as Error types #179
Conversation
|
That sounds like a good idea. Do you have an example whose behavior would change? |
23292f8 to
b51dfcb
Compare
| [(? Rep-stx a) | ||
| (if (Error? a) | ||
| `(Error ,(syntax->datum (Rep-stx a))) | ||
| (syntax->datum (Rep-stx a)))] |
There was a problem hiding this comment.
Does this make it clearer?
There was a problem hiding this comment.
The original code was fine, I'd just have moved it a line earlier. Just a nitpick anyway.
|
Re: example: No, I don't have an example that this would change behavior for. This would have changed the printing of the types of constructors for |
|
I guess what I'm asking is: in which circumstances would such types arise? |
|
One way they appear that I know of: in env/type-alias-helper.rkt the function get-type-alias-info sets the given type-aliases all to Error, to be replaced later. But then if parse-type is called on one of those types, then it will return an Error type with the given identifier as the Rep-stx I think. |
|
Ok, LGTM then. |
b51dfcb to
30cdfd1
Compare
A change like this probably would have saved me a lot of trouble debugging.