Fix resyntax permissions issue #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Resyntax workflow runs on `pull_request`, which gives it a github token with **read-only** access when run on pull requests from forks. Using `pull_request_target` instead gives it a read-write token and allows the action to submit pull request reviews for pull requests from forks.
|
Update: this didn't work. A better strategy is outlined here. I'll give that approach a try next. |
jackfirth
added a commit
to jackfirth/resyntax
that referenced
this pull request
Jul 7, 2022
This is in preparation for moving the pull request submission logic into a separate workflow, instead of performing that API call in resyntax directly. See racket/typed-racket#1253 for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Resyntax workflow runs on
pull_request, which gives it a github token with read-only access when run on pull requests from forks. Usingpull_request_targetinstead gives it a read-write token and allows the action to submit pull request reviews for pull requests from forks.