parse-type: don't inline type application #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capfredf
commented
May 24, 2022
capfredf
commented
May 24, 2022
capfredf
commented
May 24, 2022
capfredf
commented
Jun 14, 2022
capfredf
commented
Jun 14, 2022
e3c1a22 to
9ab1ed6
Compare
capfredf
commented
Jun 21, 2022
capfredf
commented
Jun 21, 2022
|
@jackfirth should the resyntax check work on files deleted in a pull request? |
|
@capfredf No, it should ignore them but it wasn't doing that. I pushed a fix to Resyntax to only analyze added and modified files. |
1. type applications are not resolved until the results are used closes racket#1234 2. streamline the handling of variances
samth
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two major changes: