Allow #:combine and #:combine/key #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for hash-union, union! and intersect
|
The test is to ensure that doing type inference for invoking |
|
I just wanted to point out that the current test will always fail, because |
|
Thanks. Currently, the type checker only throws the inference error, but I should change those two arguments to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
hash-union,hash-union!andhash-intersectSee also: https://racket.discourse.group/t/type-checker-inference-for-polymorphic-keyword-functions-not-supported/145/5
maybe related: following failing test was recently added but I think the first hash should be
#hash(). However I could be wrong about what is being testedtyped-racket/typed-racket-test/fail/hash-union.rkt
Line 3 in 20acc4b