Make PLT_TR_CONTRACTS easier to toggle in CI #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes PLT_TR_CONTRACTS so that the legal values are `"true"`, `"false"`, `""`, and unset, and only the first of those choices results in `enable-contracts?` being true. Previously, setting `PLT_TR_CONTRACTS` to any string at all (including explicitly setting it to the empty string) would enable contracts.
I made this change so I could simplify the CI setup a little, since this lets the `${{ matrix.enable-contracts }}` expression be passed directly in the environment.
bff1f1c to
34af873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes PLT_TR_CONTRACTS so that the legal values are
"true","false","", and unset, and only the first of those choices results inenable-contracts?being true. Previously, settingPLT_TR_CONTRACTSto any string at all (including explicitly setting it to the empty string) would enable contracts.I made this change so I could simplify the CI setup a little, since this lets the
${{ matrix.enable-contracts }}expression be passed directly in the environment.