Automated Resyntax fixes #1398
Merged
Automated Resyntax fixes #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated change generated by Resyntax. #### Pass 1 Applied 2 fixes to [`typed-racket-lib/typed-racket/env/type-alias-helper.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/env/type-alias-helper.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 307, `inline-unnecessary-define`: This variable is returned immediately and can be inlined. Applied 1 fix to [`typed-racket-lib/typed-racket/env/signature-env.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/env/signature-env.rkt) * Line 13, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 5 fixes to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 32, `inline-unnecessary-define`: This variable is returned immediately and can be inlined. * Line 52, `always-throwing-if-to-when`: Using `when` and `unless` is simpler than a conditional with an always-throwing branch. * Line 61, `cond-let-to-cond-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 82, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. #### Pass 2 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 3 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 4 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 5 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 6 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 7 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 8 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 9 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 10 Applied 1 fix to [`typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt`](../blob/HEAD/typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. ## Summary Fixed 17 issues in 3 files. * Fixed 12 occurrences of `tidy-require` * Fixed 2 occurrences of `inline-unnecessary-define` * Fixed 1 occurrence of `always-throwing-if-to-when` * Fixed 1 occurrence of `cond-let-to-cond-define` * Fixed 1 occurrence of `let-to-define`
jackfirth
reviewed
Oct 4, 2024
Comment on lines
+7
to
+14
| (require racket/list | ||
| racket/pretty | ||
| racket/set | ||
| rackunit | ||
| syntax/parse | ||
| (only-in racket/format ~a) | ||
| (only-in syntax/modread with-module-reading-parameterization) | ||
| "../test-utils.rkt") |
There was a problem hiding this comment.
This require form seemed to trip up Resyntax for some reason. The output looks nice, but Resyntax ran 10 passes and kept repeatedly trying to tidy these requires. Not sure what's up with that.
samth
approved these changes
Oct 5, 2024
|
This is good, but I think I'd prefer significantly larger PRs from resyntax rather than doing this a lot of times. |
|
Noted, I'll send a PR to bump up the limits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 2 fixes to
typed-racket-lib/typed-racket/env/type-alias-helper.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.inline-unnecessary-define: This variable is returned immediately and can be inlined.Applied 1 fix to
typed-racket-lib/typed-racket/env/signature-env.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 5 fixes to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.inline-unnecessary-define: This variable is returned immediately and can be inlined.always-throwing-if-to-when: Usingwhenandunlessis simpler than a conditional with an always-throwing branch.cond-let-to-cond-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Pass 2
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 3
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 4
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 5
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 6
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 7
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 8
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 9
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 10
Applied 1 fix to
typed-racket-test/unit-tests/shallow-rewrite-expansion/main.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Summary
Fixed 17 issues in 3 files.
tidy-requireinline-unnecessary-definealways-throwing-if-to-whencond-let-to-cond-definelet-to-define