Disable the #{} reader macro if a dispatch macro already exists on #\{ #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a test, and probably a mention in the docs. Otherwise, looks good. |
2bbf321 to
adcdc27
Compare
|
Added a test and notes in the documentation. |
|
Modulo that one comment, looks good to me. |
adcdc27 to
26f4d5c
Compare
|
Okay, I linked to the readtable term in the docs, but I don't think it's possible to link to the |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem when using TR with my curly-fn meta-language, which installs its own dispatch macro on
#\{. Since TR already uses that for annotations, this was overridden.This implements @samth's idea thrown out on IRC to simply disable installing the readtable if a mapping already exists for
#\{. This should never conflict with existing code, since the only way to modify a#langreadtable is through meta-langs, which are fairly rare as-is.