Resyntax testing #1313
Closed
Resyntax testing #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another test pull request to get Resyntax to behave correctly. Ignore this.
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and has added suggestions.
Comment on lines
+77
to
+79
| (define (foo) | ||
| (let ([x 1]) | ||
| (+ x x))) |
There was a problem hiding this comment.
let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
Suggested change
| (define (foo) | |
| (let ([x 1]) | |
| (+ x x))) | |
| (define (foo) | |
| (define x 1) | |
| (+ x x)) |
Debugging details
Textual replacement
(line-replacement
#:new-lines '#("(define (foo)" " (define x 1)" " (+ x x))")
#:original-lines '#("(define (foo)" " (let ([x 1])" " (+ x x)))")
#:start-line 77)Syntactic replacement
(syntax-replacement
#:introduction-scope #<procedure:do-make-syntax-introducer>
#:new-syntax
#<syntax:/home/runner/.local/share/racket/snapshot/pkgs/resyntax/default-recommendations/let-binding-suggestions.rkt:45:3 (define (foo) NEWLINE (define x 1) NEWLINE (+ x x))>
#:original-syntax
#<syntax:typed-racket-lib/typed-racket/private/type-contract.rkt:77:0 (define (foo) (let ((x 1)) (+ x x)))>)There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and has added suggestions.
Comment on lines
+77
to
+79
| (define (foo) | ||
| (let ([x 1]) | ||
| (+ x x))) |
There was a problem hiding this comment.
let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
Suggested change
| (define (foo) | |
| (let ([x 1]) | |
| (+ x x))) | |
| (define (foo) | |
| (define x 1) | |
| (+ x x)) |
Debugging details
Textual replacement
(line-replacement
#:new-lines '#("(define (foo)" " (define x 1)" " (+ x x))")
#:original-lines '#("(define (foo)" " (let ([x 1])" " (+ x x)))")
#:start-line 77)Syntactic replacement
(syntax-replacement
#:introduction-scope #<procedure:do-make-syntax-introducer>
#:new-syntax
#<syntax:/home/runner/.local/share/racket/snapshot/pkgs/resyntax/default-recommendations/let-binding-suggestions.rkt:45:3 (define (foo) NEWLINE (define x 1) NEWLINE (+ x x))>
#:original-syntax
#<syntax:typed-racket-lib/typed-racket/private/type-contract.rkt:77:0 (define (foo) (let ((x 1)) (+ x x)))>)|
It works! Closing this now. |
|
This pull request has been mentioned on Racket Discussions. There might be relevant details there: https://racket.discourse.group/t/rfc-adding-resyntax-code-reviews-to-core-racket-repositories/1746/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another test pull request to get Resyntax to behave correctly. Ignore this.