这是indexloc提供的服务,不要输入任何密码
Skip to content

adds some minor changes to the vig #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged

adds some minor changes to the vig #659

merged 1 commit into from
Jun 8, 2022

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented May 14, 2022

Additional two comments:

  1. "tm_shape() specifies the spatial data object, which can be any spatial data object from the packages sf, stars, terra, sp, and raster." - this is not true for SpatVector (from terra)
  2. The map based on the code starting on Line 114 does return a base map (for me)

@agila5
Copy link

agila5 commented May 15, 2022

Hi everyone. I will add two comments here instead of creating a new PR

  1. I think there is another typo in the tmap 4 - tmap 3.x section (bivarite should be bivariate);
  2. @Nowosad, I'm not 100% sure what you mean, but when I run the code at lines 118-123 (or 114-119 for this PR) I get a tmap object. If you want I can provide a reprex with more info.

I will try to play with tmap4 for the upcoming projects. Thanks, @mtennekes.

@Nowosad
Copy link
Member Author

Nowosad commented May 15, 2022

Hi @agila5 -- I am also getting a map, but only with borders (and I assume that there should be a base map image underneath the borders, but it is missing)

@agila5
Copy link

agila5 commented May 15, 2022

Ops, sorry you are right. I completely missed the "basemap" step...

@mtennekes mtennekes merged commit e6fbfd3 into v4 Jun 8, 2022
mtennekes added a commit that referenced this pull request Jun 8, 2022
@mtennekes
Copy link
Member

Bugs regarding SpatVector and missing basemap fixed, typo fixed. Thanks @Nowosad and @agila5 !

@Nowosad Nowosad deleted the v4vig branch June 8, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants