-
Notifications
You must be signed in to change notification settings - Fork 125
adds v4 vig improvements #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for these helpful issues @Nowosad !
1 The meta.margins are set automatically based on the occurrence of legends, however not on the content of the legends themselves (which is too complicated). I still have to play around with the default settings. I don't have implemented landscape legends yet (of course I will). The availability of landscape legends will make it possible to use the space more efficiently. For example: if the aspect ratio of the device is larger (so more landscapish) than the bounding box, then place the legends at the bottom. If (in that case) the aspect rations are not very different, use landscape legends (stacked vertically), and otherwise (so if there is much room below the map) use portrait legends stacked horizontally. 2 a) good idea to add ticks. b) will do (once implemented) |
Thanks for all of the explanations.
It makes a lot of sense. I like this trimming of |
I've updated the vignette. Please take a look @Nowosad I made some minor changes, so the code in main.r and main2.r may not work anymore (haven't tested yet). As a user, I find We already have the |
Hi @mtennekes,
I read and also tried to improve the vignette (see my changes in the PR). Additionally, I have a few comments/questions:
Functions such as tm_legend have not got any documentation. I assume that will change in the future? (Documentation would allow me to explore the possible options)
There is the tm_lp_out and tm_lp_inset functions. Would not it be easier to remember if the second function is tm_lp_in?
Is tm_layout dead/removed in tmap v4 and the users should switch to tm_options? Why did you decide to change tm_layout to tm_options?
I commented out a paragraph in the Facets sections that I was not able to understand...
You had specified colors with tmap_pals$pals.brewer$brewer.greens. Is that the final syntax, or would it be able to call palettes just with "brewer.greens"?
What is the difference between meta.margin and inner.margin/outer.margin?
I also tried to run the code in sandbox/main2.R. They are very interesting. My comments:
Legends - there is still an issue with too wide space for the outside legend (e.g., see an example in line 318)
Continuous legends - I think it would be great to (a) add legend ticks, (b) add some examples of horizontal legends (e.g., I would love to be able to easily create a horizontal legend at the bottom that would occupy the total map width)
Best,
J