这是indexloc提供的服务,不要输入任何密码
Skip to content

adds possibility of selecting other graphic devices #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2021
Merged

adds possibility of selecting other graphic devices #586

merged 4 commits into from
Aug 12, 2021

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Aug 11, 2021

Related to https://github.com/mtennekes/tmap/issues/585.
Still WIP - I plan to complete it tomorrow.

@mtennekes Do you have any tests/sandboxes for checking if everything is ok with my changes?

@mtennekes
Copy link
Member

Thanks!

The testing routine of tmap cannot be any worse: there are no tests except for the examples in the documentation.

@Nowosad
Copy link
Member Author

Nowosad commented Aug 12, 2021

Ok - it seems to be ok for your review, @mtennekes - https://github.com/mtennekes/tmap/issues/585#issuecomment-897409941

@Nowosad Nowosad marked this pull request as ready for review August 12, 2021 07:26
@mtennekes
Copy link
Member

Great! It works fine. When I made this typo:

tmap_save(m, "choropleth.pdf", device = "cairo_pdf", height = 7) # height interpreted in inches

(cairo_pdf should be unquoted) I got this not-helpful error message:

# Error in dev(filename = filename, width = width, height = height, ...) : 
#  could not find function "dev"

@Nowosad
Copy link
Member Author

Nowosad commented Aug 12, 2021

👍🏻

It should be better now:

library(tmap)
data("World")
tm = qtm(World)
tmap_save(tm, "choropleth.pdf", device = "cairo_pdf", height = 7)
#> Error: "cairo_pdf" graphic device does not exist

Created on 2021-08-12 by the reprex package (v2.0.1)

Let me know if you have better idea about the error message content.

@mtennekes mtennekes merged commit cbc0d68 into r-tmap:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants