fix #364: fix increment for when no filename given #561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
ifelse()
was reversed.This new version fixes them, by starting with a file called "tmap01" and then incrementing properly.
One remaining issue is that the increment would stop at 100 and keep replacing the file named "tmap100", but I assume it would be very unlikely that users would reach that.
I wanted to add a test using
expect_snapshot_output()
but this would require using testthat suite 3. Are there any plans to move to the latest version?