这是indexloc提供的服务,不要输入任何密码
Skip to content

improvements - background elements, id removal #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2015

Conversation

timelyportfolio
Copy link
Collaborator

For these to work, please install the newest version of svgPanZoom with

devtools::install_github("timelyportfolio/svgPanZoom")

List of improvements (ref #20):

  1. restore previously removed clipPaths and assign random id (see 3)
  2. restore previously removed background elements, such as framing rectangles, since these are important to the design of the map and considered intentional if added
  3. remove the id attribute from all SVG elements except clipPaths so that more than one map can appear within a single HTML page (composeable)

mtennekes added a commit that referenced this pull request Sep 11, 2015
improvements - background elements, id removal
@mtennekes mtennekes merged commit 901ead4 into r-tmap:master Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants