fix to get the pan up/down not reversed #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does multiple things to "improve"
tmap2svg
g
forsvgPanZoom
to use as its target viewport. Now, the pan works as expected.height
andwidth
parameters totmap2svg
that allowsheight
andwidth
separate fromtmap
while retaining the same aspect ratio.SVG
elements that don't work well in thehtmlwidget
context, such as therect
surrounding the map.Note: need the
dev/0.3.0
branch of `svgPanZoom, soHere is a working example http://bl.ocks.org/timelyportfolio/e2effb970b3cbe2f4e84.