Add shape.name to tm_shape #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtennekes
added a commit
that referenced
this pull request
Aug 21, 2017
|
Hi John, Great addition! I just made some small changes, e.g. changed "shape.name" to just "name" (as it is an argument of I try to apply the policy to include all people who made commits to the tmap code (no matter how small) in the authors list (as contributors). You you please enter your email address to https://github.com/mtennekes/tmap/blob/master/DESCRIPTION (or remove the line if you prefer to be anonymous)? |
|
Hi Martijn,
I've made a couple of other small changes that I can send along as well.
One of them turned out to be caused by a leaflet issue (see
https://stackoverflow.com/questions/45334431/interactive-output-from-tmap-has-missing-slivers-along-polygon-edges).
The fix was to add a smoothFactor argument into the call to addPolygons in
view_tmap.R
lf <- lf %>% addPolygons(data=shp, stroke=stroke, weight=gpl$lwd, color=bcol,
fillColor = fcol, opacity=bopacity, fillOpacity = fopacity, popup = popups,
options = pathOptions(clickable=!is.null(popups)), group=shp_name, layerId =
id, smoothFactor = 0.3, popupOptions = pOptions)
I had one other formatting change to allow for some very long variable
names to be displayed in popup window:
pOptions <- leaflet::popupOptions(maxWidth = "auto", maxHeight = 300)
This avoided some difficulties in trying to format the popup windows via
CSS.
Thanks again for the great package! I'm getting a lot of good use out of it.
Regards,
John
…On Mon, Aug 21, 2017 at 12:05 AM, mtennekes ***@***.***> wrote:
Hi John,
Great addition! I just made some small changes, e.g. changed "shape.name"
to just "name" (as it is an argument of tm_shape).
I try to apply the policy to include all people who made commits to the
tmap code (no matter how small) in the authors list (as contributors). You
you please enter to email address to https://github.com/mtennekes/
tmap/blob/master/DESCRIPTION (or remove the line if you prefer to be
anonymous)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/mtennekes/tmap/pull/129#issuecomment-323663229>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMqqiBzn9_46XKlM_daRV6CVv-_57znFks5saSwzgaJpZM4OmT8n>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Martijn,
First off, thank you so much for such an excellent package. I had been trying to migrate from ggplot to leaflet, but there was so much missing functionality, that I had begun to loose hope in being able to reproduce an interactive version of my work. The tmap package has been a great boon.
I wanted to plot several attributes on the same map and allow the user to use the legend to turn on and off layers as appropriate. An attribute to override the name of the shp object seems to solve the problem nicely. I must apologize in advance; I've never submitted a pull request before, so I could be going about this the entirely wrong way.
Cheers,
John
Code proposed (not sure my pull request will work)
tm_shape <- function(shp,
shape.name = NULL,
is.master = NA,
projection=NULL,
bbox = NULL,
unit = getOption("tmap.unit"),
simplify = 1,
line.center.type = c("segment", "midpoint"),
...) {
shp_name <- ifelse(is.null(shape.name) == TRUE, deparse(substitute(shp))[1], shape.name)
g <- list(tm_shape=c(as.list(environment()), list(...)))
class(g) <- "tmap"
g
}