explicit arguments in qtm function
#1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtennekes, all of the failed checks are regarding the code/documentation mismatches (please see below). Would you be able to fix this, or should I do something on my end? ❯ checking for code/documentation mismatches ... WARNING
Codoc mismatches from Rd file 'qtm.Rd':
qtm
Code: function(shp = NULL, fill = tmap::tm_const(), col =
tmap::tm_const(), size = tmap::tm_const(), shape =
tmap::tm_const(), lwd = tmap::tm_const(), lty =
tmap::tm_const(), fill_alpha = tmap::tm_const(),
col_alpha = tmap::tm_const(), text = tmap::tm_const(),
text_col = tmap::tm_const(), text_size =
tmap::tm_const(), by = NULL, scale = NULL, title =
NULL, crs = NULL, bbox = NULL, basemaps = NA, overlays
= NA, zindex = NA, group = NA, group.control =
"check", style = NULL, format = NULL, ...)
Docs: function(shp = NULL, fill = tm_const(), col = tm_const(), size
= tm_const(), shape = tm_const(), lwd = tm_const(),
lty = tm_const(), fill_alpha = tm_const(), col_alpha =
tm_const(), text = tm_const(), text_col = tm_const(),
text_size = tm_const(), by = NULL, scale = NULL, title
= NULL, crs = NULL, bbox = NULL, basemaps = NA,
overlays = NA, zindex = NA, group = NA, group.control
= "check", style = NULL, format = NULL, ...)
Mismatches in argument default values (first 3):
Name: 'fill' Code: tmap::tm_const() Docs: tm_const()
Name: 'col' Code: tmap::tm_const() Docs: tm_const()
Name: 'size' Code: tmap::tm_const() Docs: tm_const()
0 errors ✔ | 1 warning ✖ | 0 notes ✔
Error: Error: R CMD check found WARNINGs
Execution halted
Error: Process completed with exit code 1. |
|
you can run |
- Updated documentation to fix the failed checks that failed the first time.
|
That seems to fix the issue. Thanks, @olivroy! |
|
Thx @ar-puuk What email address of yours can I put in the contributors list? |
|
Thanks a lot, @mtennekes. Please use pukar.bhandari@outlook.com. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #1063. Only fixes
qtm().