Thx!

• I didn't know the %||% operator. Seems very handy! Probably could replace hundreds of tmap code lines :-)
• Your control.position cli_abort seems the other way round: the tmap standard (which deviated from leaflet) is c(<horizontal>, <vertical>)

We could also replace all stops with cli_aborts, but that has low priority...

Oops, I see what you mean now. The error message is still not accurate. I will leave that part out for now until I do more experimentation...

I would just have expected this to work...

# confusing leaflet error message
map +
    tm_view(control.bases = c("shp1", "shp2"), control.collapse = TRUE, control.position = c("top","right"))
#> Error in match.arg(position): 'arg' doit être un de "topright", "bottomright", "bottomleft", "topleft"

instead of this

map +
    tm_view(control.bases = c("shp1", "shp2"), control.collapse = TRUE, control.position = c("right","top"))

but somehow order is mixed, and I don't want to make things worse. Leaving as is for now.

Solved it the chameleon way: 4f5fa7e (

Now it accepts both c("right", "top") and c("top", "right"). This should apply to all position arguments that are short cutted via a 2-length character. Not sure if we should add a message that the former is the preferred order....

This is great! thanks for addressing this! I will investigate to see if a message / warning is required.

Are you ok merging this? I removed my commit on position.