fix!: remove puppeteer.devices in favor of KnownDevices
#9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fad8ce to
ec58951
Compare
a093fbb to
e8c6f75
Compare
e8c6f75 to
23eb397
Compare
23eb397 to
77cb445
Compare
OrKoN
reviewed
Oct 10, 2022
OrKoN
reviewed
Oct 10, 2022
3bfc570 to
81e4b8c
Compare
puppeteer.devices in favor of KnownDevices
OrKoN
approved these changes
Oct 10, 2022
81e4b8c to
6aaca76
Compare
Closed
This was referenced Oct 10, 2022
Closed
Closed
Merged
Contributor
|
is this change promoted for a reason? why 🤔 |
This was referenced Oct 21, 2022
Closed
Closed
This was referenced Nov 2, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
puppeteer.devicesin favor of a new exported objectKnownDevices.devicescan also be exported, but has been deprecated.