-
Notifications
You must be signed in to change notification settings - Fork 1.4k
adds new source facebook #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$ ./subfinder -d hackerone.com -s facebook
__ _____ __
_______ __/ /_ / __(_)___ ____/ /__ _____
/ ___/ / / / __ \/ /_/ / __ \/ __ / _ \/ ___/
(__ ) /_/ / /_/ / __/ / / / / /_/ / __/ /
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/
projectdiscovery.io
[INF] Current subfinder version v2.6.1 (latest)
[INF] Loading provider config from /Users/tarun/.config/subfinder/provider-config.yaml
[INF] Enumerating subdomains for hackerone.com
events.hackerone.com
links.hackerone.com
support.hackerone.com
mta-sts.forwarding.hackerone.com
mta-sts.hackerone.com
api.hackerone.com
gslink.hackerone.com
design.hackerone.com
info.hackerone.com
go.hackerone.com
docs.hackerone.com
mta-sts.managed.hackerone.com
www.hackerone.com
[INF] Found 13 subdomains for hackerone.com in 696 milliseconds 883 microseconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation: lgtm!
Todo:
- Functional testing (currently unable to get an api key)
|
||
var ( | ||
domainsPerPage = "1000" | ||
authUrl = "https://graph.facebook.com/oauth/access_token?client_id=%s&client_secret=%s&grant_type=client_credentials" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated and optional: somehow I think that string holding fmt formats should be more explicit or easily identifiable, with naming or maybe defining a new alias type? What do you think of implementing an enriched StringFmt type like:
// with naming
var variableNameFmt = "xxx%s"
// or with alias type
// var xxx StringFmt = "xxx%s"
// xxx.Printf(arg[0], arg[1])
type StringFmt string
func (s StringFmt) Printf(args ...interface{}) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./subfinder -d hackerone.com -s facebook
__ _____ __
_______ __/ /_ / __(_)___ ____/ /__ _____
/ ___/ / / / __ \/ /_/ / __ \/ __ / _ \/ ___/
(__ ) /_/ / /_/ / __/ / / / / /_/ / __/ /
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/
projectdiscovery.io
[INF] Current subfinder version v2.6.1 (latest)
[INF] Loading provider config from /Users/geekboy/.config/subfinder/provider-config.yaml
[INF] Enumerating subdomains for hackerone.com
mta-sts.hackerone.com
design.hackerone.com
events.hackerone.com
info.hackerone.com
mta-sts.managed.hackerone.com
api.hackerone.com
support.hackerone.com
mta-sts.forwarding.hackerone.com
gslink.hackerone.com
go.hackerone.com
links.hackerone.com
docs.hackerone.com
www.hackerone.com
[INF] Found 13 subdomains for hackerone.com in 796 milliseconds 607 microseconds
Proposed Changes