Change home directory recovery method #903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@wall6e see projectdiscovery/utils#172; this change will be added in all the PD projects via utils library upon next release. |
Member
|
Member
|
@wall6e Thanks for your PR. Unfortunately I think the changes might not fix the issue as they are related to potential outdated code #930, additionally projectdiscovery/utils#172 doesn't address this particular scenario as https://github.com/projectdiscovery/utils/blob/cc554490e5c6deb0ce47330091c457e10992240a/folder/folderutil.go#L149 uses |
Member
|
Fixed in #1013, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to use
os.UserHomeDir()instead ofusr.Current().HomeDirplease ?To my knowledge
os.UserHomeDir()is the only function which take environment variables into account. On Unix, including macOS, it returns the $HOME environment variable. On Windows, it returns %USERPROFILE%.More details can be found in the official documentation:
https://pkg.go.dev/os#UserHomeDir
See the test case below:
The current state causes problems, for example, when using subfinder in an aws lambda. The home directory retrieved with
usr.Current().HomeDiris "/home/sbx_user1051", whereas this part of the file system is impracticable because is read-only . As it stands, setting the environment variable $HOME doesn't get around this problem, and it's impossible to use a custom configuration.See below, the output of the
echo 'HOME='\$HOME; /go/bin/subfinder -d xxxx.comcommands: