-
Notifications
You must be signed in to change notification settings - Fork 1.5k
resolve failing cases #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
crtsh and commoncrawl errors are very random. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - not related but I'd like to propose removing push from github actions:
on:
push:
pull_request:
The interested actions are:
- build-test.yml
- lint-test.yml
Mzack9999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - faulty sources removal tracked at #722
| }, | ||
| Dial: (&net.Dialer{ | ||
| Timeout: time.Duration(timeout) * time.Second, | ||
| }).Dial, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout is set when the http.client is initialized, this is a dup.
No description provided.