这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ShubhamRasal
Copy link
Contributor

No description provided.

@ShubhamRasal ShubhamRasal self-assigned this Nov 25, 2022
@ShubhamRasal ShubhamRasal marked this pull request as draft November 25, 2022 13:29
@ShubhamRasal ShubhamRasal added the Status: In Progress This issue is being worked on, and has someone assigned. label Nov 25, 2022
@ShubhamRasal ShubhamRasal linked an issue Nov 25, 2022 that may be closed by this pull request
1 task
@ShubhamRasal
Copy link
Contributor Author

crtsh and commoncrawl errors are very random.
most of the time tests fails due to 503, and connection timeout error of sources.

@ShubhamRasal ShubhamRasal marked this pull request as ready for review November 28, 2022 07:19
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - not related but I'd like to propose removing push from github actions:

on:
  push:
  pull_request:

The interested actions are:

  • build-test.yml
  • lint-test.yml

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - faulty sources removal tracked at #722

@Mzack9999 Mzack9999 requested a review from ehsandeep November 29, 2022 12:45
@ehsandeep ehsandeep merged commit 8cc8f25 into dev Nov 29, 2022
@ehsandeep ehsandeep deleted the issue-678-resolve-failing-cases branch November 29, 2022 12:49
@ehsandeep ehsandeep removed the Status: In Progress This issue is being worked on, and has someone assigned. label Nov 29, 2022
},
Dial: (&net.Dialer{
Timeout: time.Duration(timeout) * time.Second,
}).Dial,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout is set when the http.client is initialized, this is a dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing integration tests for crtsh and waybackarchive

5 participants