Fixed crt.sh SQL query #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/K-6Vymd_AAAJ and using the &showSQL=y parameter I noticed the source's SQL is quite different of the current SQL crts.sh is using
ehsandeep
reviewed
Nov 17, 2022
Member
ehsandeep
left a comment
There was a problem hiding this comment.
Thank you, I can confirm the consistency issue is now fixed, I also noticed now crtsh returns root domain name (keyloop.com) as part of the output, was it expected to change @vzamanillo?
Contributor
Author
|
Hey! let me check what's going on. |
Contributor
Author
|
Before the fix: After the fix: Web browser request results (HTML output): Web browser request results (JSON output) Yes, it's expected, also, it returns +3 results. We can exclude the root domain, but I think that should be done for the set of all results, not just this source, I mean, here. |
Mzack9999
approved these changes
Nov 21, 2022
ehsandeep
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #666, also implements the #676 changes (email name values)