add source recon.cloud (without api key and for free) #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm a little confused as to why it fails the compile test. |
Mzack9999
approved these changes
Oct 23, 2022
Member
Mzack9999
left a comment
There was a problem hiding this comment.
lgtm - implementation is fully functional besides weird integration tests failure:
$ echo hackerone.com | go run . -s reconcloud -v
...
[DBG] Selected source(s) for this search: reconcloud
[INF] Enumerating subdomains for 'hackerone.com'
[reconcloud] resources.hackerone.com
[reconcloud] gslink.hackerone.com
[reconcloud] Source took 540.9794ms for enumeration
resources.hackerone.com
gslink.hackerone.com
[INF] Found 2 subdomains for 'hackerone.com' in 543 milliseconds 954 microseconds
Contributor
Author
|
Sorry, wrong click @Mzack9999 |
Member
Contributor
Author
|
Ok, both PR are fine, hopefully, they will be processed and merged into the master branch soon |
Member
Contributor
|
recon.cloud is now checking for a secure connection via JavaScript, this source is not functional anymore, but... what about a headless request implementation to use with this kind of sources? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This source is very interesting, and maybe everyone will like it.