这是indexloc提供的服务，不要输入任何密码
Skip to content

Create/aggregate tests for providers that do NOT require an API key #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2022
Merged

Create/aggregate tests for providers that do NOT require an API key #652

merged 4 commits into from
Oct 4, 2022

Conversation

@forgedhallpass
Copy link
Contributor

@forgedhallpass forgedhallpass commented Sep 28, 2022

No description provided.

@forgedhallpass forgedhallpass linked an issue Sep 28, 2022 that may be closed by this pull request
Create/aggregate tests for providers that do NOT require an API key #649
Closed
@forgedhallpass
test refactor: Create/aggregate tests for providers that do NOT requi…
a527ae3 
…re an API key #649

There is no need to check for empty domains, because that is validated at CLI flag validation time.
@forgedhallpass forgedhallpass marked this pull request as ready for review September 30, 2022 16:07
@forgedhallpass
Copy link
Contributor Author

forgedhallpass commented Sep 30, 2022

For the tests to pass, it requires completion of #654, in which non-functional sources has been removed.

ehsandeep
ehsandeep requested changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

@forgedhallpass
Copy link
Contributor Author

forgedhallpass commented Sep 30, 2022

The test now fails because commoncrawl is not stable. Sometimes it work, sometimes it doesn't...

<html>
<head><title>504 Gateway Time-out</title></head>
<body>
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.18.0 (Ubuntu)</center>
</body>
</html>
<!-- a padding to disable MSIE and Chrome friendly error page -->

@forgedhallpass forgedhallpass merged commit c6666b0 into dev Oct 4, 2022
@forgedhallpass forgedhallpass deleted the tests branch October 4, 2022 11:17
@Mzack9999 Mzack9999 mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create/aggregate tests for providers that do NOT require an API key

4 participants

@forgedhallpass @ehsandeep @dogancanbakir