Sources refactor and bug fixes #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the sources self-contained: information related to whether a source is default, recursive or if it requires API keys
Move provider keys into sources
This could have been a problem if the application was used as a library.
# Conflicts: # v2/go.sum # v2/pkg/runner/enumerate.go # v2/pkg/runner/options.go
* includes newer version of gologger that support MsgFunc * removed unused sliceutil dependency
ehsandeep
reviewed
Aug 18, 2022
Member
ehsandeep
left a comment
There was a problem hiding this comment.
echo example.com | ./subfinder -s DNSDB -v
echo example.com | ./subfinder -s dnsdb -v
Both results into
[WRN] There is no source with the name: 'dnsdb'
* Sources are now lower cased to prevent such issues happening in the future * DNSDB was also manually lower cased
* Warn about missing keys * Displaying the response body of failed request
Contributor
Author
Good catch. That was the only source that was not lower case. The issue is now fixed and I've also added extra debug information to help with the troubleshooting. Case 1 - Missing API key for the selected source: Case 2 - Bad API key: |
Merged
ehsandeep
approved these changes
Aug 19, 2022
Mzack9999
requested changes
Aug 22, 2022
* If the user has the provider API keys saved in the config.yaml, but doesn't have a provider-config.yaml, then the logic will migrate those keys to the new location.
* BeVigil Source Added * updated readme.md * updated .gitignore * fmt sources Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* reasoning: the performance penalty is not that notable, hence it was rather preferred to make it future-proof by preventing potential data races with maps in closures
Ice3man543
reviewed
Aug 23, 2022
Ice3man543
reviewed
Aug 23, 2022
Ice3man543
reviewed
Aug 23, 2022
Ice3man543
reviewed
Aug 23, 2022
Ice3man543
reviewed
Aug 24, 2022
Ice3man543
reviewed
Aug 24, 2022
87d903a to
d2ba13d
Compare
Ice3man543
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Bug fixes:
chinazsource when all the sources are requestedfullhuntprovider key to expect YAML instead of JSON