v2/pkg/runner: code deduplication in config.go #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix release
fix readme golang demo for v2.5.0
bugfix release
Refactor code for retrieving random slice entries, as well as parsing multipart keys, into two functions: - randomEntry for random slice entries - multipartKey for multipart key parsing This shouldn't be functionally different, but it does remove a bunch of duplicate lines of code.
Mzack9999
approved these changes
Apr 26, 2022
ehsandeep
approved these changes
Apr 26, 2022
Member
ehsandeep
left a comment
There was a problem hiding this comment.
Thank you @jalavosus for making this improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code for retrieving random slice entries, as well as parsing
multipart keys, into two functions:
- randomEntry for random slice entries
- multipartKey for multipart key parsing
This shouldn't be functionally different, but it does remove a bunch of
duplicate lines of code.