Fix #747 - SecurityTrails double subdomains #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarunKoyalwar
approved these changes
May 29, 2023
Member
tarunKoyalwar
left a comment
There was a problem hiding this comment.
lgtm!
$ ./subfinder -d "in.net" -s securitytrails -silent 130 ↵
tiffanyjewelry.in.net
airmax2015.in.net
whm.speedbroadbandchennai.in.net
cpanel.legal-metrology.ajaydemo.in.net
1111bvsvdfvs.in.net
icloud.com.findmy.in.net
Contributor
Author
|
For some context (was in a bit of a hurry when doing this PR), as far as I'm aware, the ST subdomain API used to return only the subdomain strings, hence the code for appending the domain, but now returns the full subdomain.domain.TLD. Haven't been able to find a changelog anywhere though 🤷 |
ehsandeep
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.