@donners Nice work with the PRs. These are the things i would love to see in subfinder. I'll review and merge your PR asap! Thanks for the excellent contributions.

@donners btw, i checked your fork and liked feature to show time taken by each source. Added it to subfinder in PR #223

@donners, i'm not merging this as of now. Let's aim this for the next release since it'll require a complete rework of the way we handle errors. Thanks for creating this PR.

@Ice3man543 awesome, thanks for looking at these changes!

No worries, in my case I'm calling Agent.EnumerateSubdomains() directly, so I probably missed some of the implications of these changes outside of that.

again thank you @donners for the PR on this, I'm closing this for now as possible changes have been already implemented.

Thanks for following up @bauthard! Could you point me to the changes that were implemented?

Hey, I was pointing to #220 (comment) but I will check with @Ice3man543 again if we are going to do more improvements here and will keep you updated.

Ah right. That comment was not related to this PR. It looks like 4xx/5xx status codes and dnsdumpster/hackertarget rate limits are still being ignored. Robust error handling is pretty important for my use case, would be great to see this handled properly in the source.

Right, so I'm going to create an issue for this for visibility.