Fix #199 #209
Closed
Fix #199 #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing multiple iterations, ensure the first one is actually overwriting the output, as this is the default behavior. Successive enumerations in the batch will append the results instead.
Member
|
Hey, This seems good. I will make some changes to align the code with the default code style, but overall nice work. Thanks for the PR. I'll try to merge it asap! |
Author
|
Cool thanks, happy to help out! |
Member
|
Hey, i wanted compatability with -o and -oD flag while working. So i used an alternate way to implement the functionality. Anyway, thank you so much for the PR. Appreciated a lot! Check the PR below for the current implementation - Closing this PR now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way of solving issue #199: when multi-domain enumerations are performed, the output file is now overwritten at the first enumeration and successive enumerations will append the results instead.
This is consistent with the default behavior of overwriting the output file if the user supplied one.
Not sure if code style and/or the general idea fits the "subfinder" way of doing things though, let me know!