这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@himanshudas
Copy link
Contributor

Updating commoncrawl to include results from year - 2020

Updating commoncrawl to include results from year - 2020
@ehsandeep
Copy link
Member

Hi @himanshudas,

I've checked this PR, and while inspecting results, it doesn't add more numbers but more prone to timeout error because of response time from commoncrawl.

[WRN] Could not run source commoncrawl: context deadline exceeded (Client.Timeout or context cancellation while reading body)

do you still believe adding another year will be a good idea?

@himanshudas
Copy link
Contributor Author

Hello @bauthard ,

Thanks a lot for reviewing the commit. I didn't get timeouts during execution. However, commoncrawl as an independent source seems to be slow even without year addition.

This does add few new subdomains but with a trade-off performance.

Please, feel feel to close the PR in case you see no value addition 👍

I've removed one year from last, to have latest results and removed last one to make sure we don't get timedout on most runs.
@ehsandeep
Copy link
Member

Hi @himanshudas,

Thank you for the feedback, so I've removed one year from the last to make sure we don't get timed out frequently and keep the latest year to make sure we have the latest results, merging this now.

@ehsandeep ehsandeep merged commit f093922 into projectdiscovery:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants