fix: shodan source filter subdomains properly #1388
Conversation
|
Fixing the tests |
|
Seems like the previous implementation was already correct, right? I don't see any results outside of what I had input. What am I missing here? How are you reproducing this issue? It would be better if you could go ahead and create the issue first. |
|
Sure thing, here is the issue with screenshots and clearer explanation. PS: I think example.com is not a great example 😅 I just saw that the shodan API returns barely anything on that, it's better to use hackerone.com |
|
I think we're all OK here, thanks for the help @dwisiswant0 ! This should greatly increase quality, the difference is significant, from 70 subdomains on analysiscenter.veracode.com, to 4, the bug was generating quite some false positives |
|
Superseded by #1392 |
Hi ! I noticed that the Shodan source was completely falsely reporting subdomains when querying a subdomain.
Shodan returns all subdomains they can find under the parent domain from the query (if you ask
api.example.com, you get all subdomains forexample.comregardless.)Their API response format is
{ "domain": "example.com", "tags": [], "subdomains": [], "data": [], "more": true }The bug was that we assembled the subdomains with the queried subdomain, making fake subdomains attached to the queried domain.
Query:
test.example.comActual subdomains under example.com:
Current bug output:
Expected: