这是indexloc提供的服务，不要输入任何密码
Skip to content

Allow comments in domains file #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Allow comments in domains file #1215

wants to merge 4 commits into from

Conversation

avivkeller
Copy link
Contributor

@avivkeller avivkeller commented Apr 5, 2024 •
edited by dogancanbakir
Loading

This pull requests allows the domains file to have comments, prefixed with #. It strips everything after # character, and then does not process empty lines. Closes #1333.

I.E.

# ProjectDiscovery
projectdiscovery.org # This is the main site
example.com # This is a demo website

Will be processed as

projectdiscovery.org
example.com

@avivkeller
Copy link
Contributor Author

If this PR is approved, I can squash if need be.

@GeorginaReeder
Copy link

Thanks for your contribution @redyetidev , we appreciate it! :)

dogancanbakir
dogancanbakir requested changes Aug 5, 2024
View reviewed changes
@dogancanbakir dogancanbakir mentioned this pull request Aug 5, 2024
Closed
@dogancanbakir dogancanbakir mentioned this pull request Aug 13, 2024
Merged
@dogancanbakir
Copy link
Member

raised new pr #1346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow comments in domains file
4 participants
@avivkeller @GeorginaReeder @dogancanbakir @ehsandeep