这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dogancanbakir
Copy link
Member

Closes #1174

@dogancanbakir dogancanbakir self-assigned this Feb 29, 2024
@dogancanbakir dogancanbakir changed the title remove time.sleep from sitedossier remove time.sleep from sources Feb 29, 2024
@dogancanbakir dogancanbakir marked this pull request as ready for review February 29, 2024 21:30
@dogancanbakir dogancanbakir requested a review from Mzack9999 March 15, 2024 09:55
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to double check if this update is due to server side loosening of rate limits (for example GH has still the same rate limits of implementation time)

@dogancanbakir
Copy link
Member Author

I believe that before #891, we were trying to limit the requests with time.Sleep. Since we now have this feature, we no longer need those. So, this PR simply removes them and, if necessary, adds default rate limits for sources.

@ehsandeep ehsandeep merged commit 3a52a8e into dev Mar 15, 2024
@ehsandeep ehsandeep deleted the remove_time_sleep branch March 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove time.sleep from sources

4 participants