remove scheme #1166
Merged
remove scheme #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ignore failing test, fixed in #1167 |
Mzack9999
approved these changes
Mar 15, 2024
Member
Mzack9999
left a comment
There was a problem hiding this comment.
lgtm - What do you think about declaring a global var and reusing it this way:
r := strings.NewReplacer(
"*.", "",
"http://", "",
"https://", "",
)
...
subdomain = r.Replace(subdomain)
Mzack9999
approved these changes
Mar 15, 2024
ehsandeep
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1152