这是indexloc提供的服务，不要输入任何密码
Skip to content

Purge dead binaryedge source #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Purge dead binaryedge source #1592

merged 2 commits into from
Jun 16, 2025

Conversation

@x-stp
Copy link
Contributor

@x-stp x-stp commented Jun 7, 2025 •
edited by coderabbitai bot
Loading

Purges the references to dead binaryedge source.

#1579

Summary by CodeRabbit

  • Bug Fixes
    • Removed support for the BinaryEdge source from passive subdomain enumeration.
  • Tests
    • Updated test data to reflect the removal of the BinaryEdge source.

@coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2025 •
edited
Loading

Walkthrough

The BinaryEdge source integration for passive subdomain enumeration was removed. This included deleting the BinaryEdge source module, updating the sources registry, and adjusting related test expectations to exclude BinaryEdge. No other sources or logic were modified.

Changes

File(s) Change Summary
v2/pkg/passive/sources.go Removed import and registration of the BinaryEdge source.
v2/pkg/passive/sources_test.go Updated expected source lists in tests to remove "binaryedge".
v2/pkg/subscraping/sources/binaryedge/binaryedge.go Deleted the BinaryEdge source implementation, including all methods, helpers, and struct definitions.

Poem

A hop and a skip, BinaryEdge is gone,
The code is now lighter, the list moves on.
Tests wave goodbye, their checks now less,
The garden of sources is one root less.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98e6789 and 70d6dfd.

📒 Files selected for processing (3)
  • v2/pkg/passive/sources.go (0 hunks)
  • v2/pkg/passive/sources_test.go (0 hunks)
  • v2/pkg/subscraping/sources/binaryedge/binaryedge.go (0 hunks)
💤 Files with no reviewable changes (3)
  • v2/pkg/passive/sources.go
  • v2/pkg/passive/sources_test.go
  • v2/pkg/subscraping/sources/binaryedge/binaryedge.go
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@x-stp
Copy link
Contributor Author

x-stp commented Jun 7, 2025

@coderabbitai generate docstrings

@coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2025

✅ Actions performed

Docstrings generation started.

@coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2025

Caution

No docstrings were generated.

@x-stp
Copy link
Contributor Author

x-stp commented Jun 7, 2025

@coderabbitai bad bot

@coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2025

Tip

For best results, initiate chat on the files or code changes.

@x-stp I understand your frustration! The docstring generation didn't produce results because this PR is primarily about removing code rather than adding new functionality.

When you're deleting an entire source module (like the BinaryEdge implementation), removing imports, and updating test expectations, there isn't any new code that would benefit from documentation. The docstring generator looks for new or modified functions, methods, and classes that need documentation, but in this case, the main change is deletion of the binaryedge.go file and cleanup of references.

For future PRs that add new functionality, the docstring generation should work as expected! 🤖

@x-stp
Copy link
Contributor Author

x-stp commented Jun 7, 2025

@coderabbitai good bot

@coderabbitai
Copy link

coderabbitai bot commented Jun 7, 2025

Tip

For best results, initiate chat on the files or code changes.

@x-stp Thank you! I appreciate the feedback. Happy to help with code reviews and explanations anytime! 🚀

@dogancanbakir
Copy link
Member

dogancanbakir commented Jun 10, 2025 •
edited
Loading

Thanks for the PR! I'll review it asap.

@c3l3si4n c3l3si4n mentioned this pull request Jun 16, 2025
Merged
@ehsandeep ehsandeep merged commit 423c732 into projectdiscovery:dev Jun 16, 2025
7 of 8 checks passed
@ehsandeep ehsandeep linked an issue Jun 16, 2025 that may be closed by this pull request
binaryedge is dead #1579
Closed
@ehsandeep
Copy link
Member

ehsandeep commented Jun 16, 2025

Thank you @x-stp

@x-stp x-stp deleted the fix/dead-binaryedge branch June 16, 2025 18:32
@BrewTestBot BrewTestBot mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

binaryedge is dead

3 participants

@x-stp @dogancanbakir @ehsandeep