这是indexloc提供的服务，不要输入任何密码
Skip to content

Update installation doc #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Update installation doc #1591

merged 1 commit into from
May 20, 2025

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented May 20, 2025 •
edited by coderabbitai bot
Loading

Closes #1589

Summary by CodeRabbit

  • Documentation
    • Updated installation instructions to require Go version 1.24 or higher.

@dogancanbakir dogancanbakir requested a review from ehsandeep May 20, 2025 13:13
@dogancanbakir dogancanbakir self-assigned this May 20, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 20, 2025 •
edited
Loading

Walkthrough

The README.md file was updated to change the minimum required Go version for installing subfinder from go1.21 to go1.24. The installation command itself remains unchanged, with only the documented Go version being modified.

Changes

File(s) Change Summary
README.md Updated minimum required Go version from 1.21 to 1.24 in installation instructions

Assessment against linked issues

Objective Addressed Explanation
Update documentation to reflect that subfinder requires Go 1.24.3 or higher (#1589) ✅
Resolve documentation mismatch between required Go version and actual dependency requirements (#1589) ✅

Poem

The README's been trimmed, a version anew,
Go one-two-four is now what you must do!
No more confusion, the docs are in line,
Install with confidence—your build will be fine.
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7381d and 1d55592.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🔇 Additional comments (1)
README.md (1)

114-114:

✅ Verification successful

Ensure Go version bump is consistent across the repository.

The README now specifies go1.24, which is appropriate if the project truly requires Go 1.24. Please verify and update any other pinning of Go versions to maintain consistency:

  • Confirm go.mod uses go 1.24
  • Update CI workflows (e.g., .github/workflows) that may still reference Go 1.21

Run this script to verify all references are updated:

🏁 Script executed:

#!/bin/bash
# Verify the Go version in go.mod and CI configs

# Check go.mod for the go directive
echo "go.mod contains:"
grep -R "go [0-9]\+\.[0-9]\+" go.mod

# Search CI workflows (and other files) for old Go version references
echo "Scanning for deprecated Go version references..."
rg -n "go1\.21" .github/workflows || echo "No occurrences of 'go1.21' found."

Length of output: 405

🏁 Script executed:

#!/bin/bash
set -e

echo "=== Searching for go.mod files ==="
fd --type f go.mod || echo "No go.mod file found."

echo -e "\n=== Displaying go directives from found go.mod files ==="
for file in $(fd --type f go.mod); do
  echo "File: $file"
  grep -R "go [0-9]\+\.[0-9]\+" "$file" || echo "  ⟷ No 'go x.y' directive found in $file"
done

echo -e "\n=== Searching for CI configuration files (*.yml, *.yaml) ==="
fd --type f -e yml -e yaml || echo "No YAML files found."

echo -e "\n=== Scanning entire repo for deprecated Go version references (go1.21) ==="
rg -n "go1\.21" . || echo "No occurrences of 'go1.21' found."

Length of output: 832

Go version bump verified across the repo
The v2/go.mod file specifies go 1.24.0, and no references to the old go1.21 were found in any configuration or workflow files. No further updates are needed.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ehsandeep ehsandeep merged commit 98e6789 into dev May 20, 2025
3 checks passed
@ehsandeep ehsandeep deleted the update_installation_doc branch May 20, 2025 13:30
@BrewTestBot BrewTestBot mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Latest subfinder version requires go 1.24.3 and causes a conflict on windows cause it relies on zcrypto

3 participants

@dogancanbakir @ehsandeep