这是indexloc提供的服务，不要输入任何密码
Skip to content

remove hunter #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

remove hunter #1662

merged 1 commit into from
Oct 20, 2025
+0 −136

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Oct 20, 2025 •
edited by coderabbitai bot
Loading

closes #1661

Summary by CodeRabbit

  • Chores
    • Removed the Hunter reconnaissance source and updated related test data accordingly.

@dogancanbakir dogancanbakir self-assigned this Oct 20, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025 •
edited
Loading

Walkthrough

The Hunter subscraping source has been completely removed from the codebase. This includes deletion of the hunter implementation file, removal of the hunter source from the public AllSources registry, and removal of corresponding test data entries. The removal was prompted by consistent 403 HTTP errors from the Hunter API.

Changes

Cohort / File(s) Summary
Hunter source removal from passive registry
pkg/passive/sources.go, pkg/passive/sources_test.go		 Removed &hunter.Source{} entry from the AllSources composite literal and the corresponding hunter package import. Updated test data slices expectedAllSources and expectedDefaultSources to exclude the "hunter" entry.
Hunter source implementation deletion
pkg/subscraping/sources/hunter/hunter.go		 Complete file removal of the Hunter subscraping source, including all data structures (hunterResp, infoArr, hunterData), the Source type with its fields, the Run method with API key rotation and JSON decoding logic, and all public methods (Name, IsDefault, HasRecursiveSupport, NeedsKey, AddApiKeys, Statistics).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

The changes are homogeneous and straightforward: consistent removal of the Hunter source across three files with no complex logic interactions or conditional dependencies to validate. The edits are repetitive in nature (registry removal, test data cleanup, and file deletion).

Poem

🐰 A hunter once roamed through the digital trees,
But 403s came with a cryptic wheeze.
Now gone are the hops, the API calls fade,
The rabbit moves on to a better arcade! 🌙

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "remove hunter" is concise, clear, and directly describes the primary change in the pull request. It accurately summarizes the main objective of eliminating the hunter source integration from the codebase without unnecessary verbosity or vague terminology. The title is specific enough that a teammate reviewing the repository history would immediately understand what this changeset addresses.
Linked Issues Check ✅ Passed The linked issue #1661 specifies the objective to remove the Hunter integration due to consistently receiving HTTP 403 responses. The pull request fully addresses this requirement by removing the hunter source from the public AllSources slice, eliminating the hunter package import, removing the entire hunter implementation file (pkg/subscraping/sources/hunter/hunter.go), and updating all related test data to reflect the removal. These changes directly accomplish the coding requirements stated in the linked issue.
Out of Scope Changes Check ✅ Passed All changes in the pull request are directly aligned with the scope of removing the Hunter integration. The modifications include removing hunter from the AllSources slice, updating related test expectations, and deleting the hunter implementation file—all of which are necessary and directly related to the stated objective. No extraneous changes, unrelated refactoring, or modifications to other sources are present in this changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 1661_remove_hunter
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7396f0d and bc7edda.

⛔ Files ignored due to path filters (1)
  • .github/workflows/build-test.yml is excluded by !**/*.yml
📒 Files selected for processing (3)
  • pkg/passive/sources.go (0 hunks)
  • pkg/passive/sources_test.go (0 hunks)
  • pkg/subscraping/sources/hunter/hunter.go (0 hunks)
💤 Files with no reviewable changes (3)
  • pkg/passive/sources.go
  • pkg/passive/sources_test.go
  • pkg/subscraping/sources/hunter/hunter.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Test Builds (macOS-latest)
  • GitHub Check: Test Builds (ubuntu-latest)
  • GitHub Check: Test Builds (windows-latest)
  • GitHub Check: release-test
  • GitHub Check: Analyze (go)

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir linked an issue Oct 20, 2025 that may be closed by this pull request
[Issue] Error with sources: Hunter, Alienvault #1658
Closed
@Mzack9999 Mzack9999 merged commit 3d6441b into dev Oct 20, 2025
8 of 10 checks passed
@Mzack9999 Mzack9999 deleted the 1661_remove_hunter branch October 20, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Hunter [Issue] Error with sources: Hunter, Alienvault

3 participants

@dogancanbakir @Mzack9999