Adds the urlscan source. #1644
Closed
Adds the urlscan source. #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ehsandeep Thanks for pointing that out! 🙏 |
Author
|
@ehsandeep I re-ran the tests locally with The Ubuntu CI failure seems unrelated to the urlscan implementation — The urlscan source itself is working correctly. |
Member
|
Just a reminder: #957 (comment) |
Author
|
@dogancanbakir Thanks for the review. I understand the concern about strict rate limits—it makes sense. Would you like me to close this PR, or will you handle it? I’m fine either way. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new passive source integration for urlscan.io into Subfinder.
Changes
pkg/subscraping/sources/urlscan/urlscan.goSourceinterface with pagination, deduplication, and basic retry/backoffurlscaninAllSources(passive.go)sources_test.goto includeurlscanMotivation
urlscan.io provides subdomain data from scanned URLs and pages.
Integrating it into Subfinder increases overall passive coverage and improves discovery results.
Related Issue
Closes #1643