move v2 module code to root directory for cleaner structure #1613

mikelolasagasti · 2025-07-10T13:30:34Z

Keeps module path as github.com/projectdiscovery/subfinder/v2 to preserve import compatibility.

Summary by CodeRabbit

Chores
- Updated build configuration to simplify directory structure and binary location in the Docker image.

Keeps module path as github.com/projectdiscovery/subfinder/v2 to preserve import compatibility. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

coderabbitai · 2025-07-10T13:30:43Z

Walkthrough

The Dockerfile was updated to keep the working directory as /app instead of switching to /app/v2 during the build process. The path for copying the built binary in the final image was also changed to match the new directory structure, referencing /app/subfinder instead of /app/v2/subfinder.

Changes

File(s)	Change Summary
Dockerfile	Updated build and copy paths to use `/app` instead of `/app/v2` for the binary

Poem

In Docker’s warren, paths align,
No more burrowing into /v2 this time.
The binary hops to /app with glee,
Simpler trails for all to see.
A tidy burrow, neat and bright—
Subfinder’s home is set just right! 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ae782a and 0d9014e.

⛔ Files ignored due to path filters (5)

.github/workflows/build-test.yml is excluded by !**/*.yml
.github/workflows/compat-checks.yaml is excluded by !**/*.yaml
.github/workflows/dockerhub-push.yml is excluded by !**/*.yml
.github/workflows/release-binary.yml is excluded by !**/*.yml
.github/workflows/release-test.yml is excluded by !**/*.yml

📒 Files selected for processing (1)

Dockerfile (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Lint Test
GitHub Check: Analyze (go)
GitHub Check: release-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dockerfile (1)
6-6: Remove redundant WORKDIR /app instruction

WORKDIR /app is already set on line 4, so this second declaration creates an unnecessary layer and may confuse future maintainers.
-WORKDIR /app

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3674ed and 9ae782a.

⛔ Files ignored due to path filters (2)

.goreleaser.yml is excluded by !**/*.yml
go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

Dockerfile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Analyze (go)

🔇 Additional comments (1)

Dockerfile (1)

14-14: LGTM – updated COPY path is correct

The change correctly mirrors the new build location of the subfinder binary at /app/subfinder. No further action needed.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

mikelolasagasti · 2025-07-10T14:12:46Z

Tests are failing with non-related issues:

=== RUN   TestSourcesWithoutKeys/rapiddns
    sources_wo_auth_test.go:76: 
        	Error Trace:	/home/runner/work/subfinder/subfinder/pkg/passive/sources_wo_auth_test.go:76
        	Error:      	Not equal: 
        	            	expected: <nil>(<nil>)
        	            	actual  : *reflect.rtype(&reflect.rtype{t:abi.Type{Size_:0x8, PtrBytes:0x8, Hash:0x6a5b1366, TFlag:0x9, Align_:0x8, FieldAlign_:0x8, Kind_:0x36, Equal:(func(unsafe.Pointer, unsafe.Pointer) bool)(0x410a80), GCData:(*uint8)(0x163b710), Str:60468, PtrToThis:0}})
        	Test:       	TestSourcesWithoutKeys/rapiddns
        	Messages:   	rapiddns: Get "https://rapiddns.io/subdomain/hackerone.com?page=1&full=1": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

dogancanbakir · 2025-07-12T05:45:29Z

Thanks for the PR!

Mzack9999

lgtm - rapiddns.io error tracked at #1615

refactor: move v2 module code to root directory for cleaner structure

6867e07

Keeps module path as github.com/projectdiscovery/subfinder/v2 to preserve import compatibility. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

coderabbitai bot reviewed Jul 10, 2025

View reviewed changes

mikelolasagasti force-pushed the remove-v2 branch from 393b06e to be9dab1 Compare July 10, 2025 13:37

mikelolasagasti added 2 commits July 10, 2025 15:39

refactor: change Dockerfile paths

51f1cd9

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>

refactor: adapt workflows to new non-v2 paths

0d9014e

mikelolasagasti force-pushed the remove-v2 branch from be9dab1 to 0d9014e Compare July 10, 2025 13:40

dogancanbakir approved these changes Jul 12, 2025

View reviewed changes

dogancanbakir requested a review from Mzack9999 July 12, 2025 05:45

Mzack9999 approved these changes Jul 15, 2025

View reviewed changes

Mzack9999 merged commit b12abbb into projectdiscovery:dev Jul 15, 2025
7 of 10 checks passed

Mzack9999 linked an issue Jul 15, 2025 that may be closed by this pull request

[Issue] Reorganize repository semantic version from directory structure #1616

Closed

Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jul 15, 2025

BrewTestBot mentioned this pull request Sep 26, 2025

subfinder 2.9.0 Homebrew/homebrew-core#245805

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

move v2 module code to root directory for cleaner structure #1613

move v2 module code to root directory for cleaner structure #1613

Uh oh!

mikelolasagasti commented Jul 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 10, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

mikelolasagasti commented Jul 10, 2025

Uh oh!

dogancanbakir commented Jul 12, 2025

Uh oh!

Mzack9999 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

move v2 module code to root directory for cleaner structure #1613

move v2 module code to root directory for cleaner structure #1613

Uh oh!

Conversation

mikelolasagasti commented Jul 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

mikelolasagasti commented Jul 10, 2025

Uh oh!

dogancanbakir commented Jul 12, 2025

Uh oh!

Mzack9999 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mikelolasagasti commented Jul 10, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)