这是indexloc提供的服务，不要输入任何密码
Skip to content

Added one line command to get binary in linux #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added one line command to get binary in linux #1609

wants to merge 1 commit into from

Conversation

@green-echooooo
Copy link

@green-echooooo green-echooooo commented Jun 21, 2025 •
edited by coderabbitai bot
Loading

Added one line command to get binary in linux operating system.

Summary by CodeRabbit

  • Documentation
    • Updated the installation instructions in the README to include a one-line shell command for downloading and extracting the latest Linux binary release, providing a more convenient setup option for Linux users.

@green-echooooo
Added one line command to get binary in linux
d37a8a0 
Added one line command to get binary in linux operating system.
@coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025 •
edited
Loading

Walkthrough

The README file was updated to include a new shell command for Linux users to download and extract the latest subfinder binary directly from GitHub releases. This command automatically detects the system architecture and retrieves the corresponding binary, providing an alternative installation method alongside the existing Go installation instructions.

Changes

File(s) Change Summary
README.md Added a shell command to download and extract the latest Linux binary for subfinder from GitHub.

Poem

A shell command hops into view,
For Linux friends, it’s something new!
Fetching binaries with a single line,
Detecting your arch—how divine!
The README grows, the setup’s neat,
Now getting subfinder is truly a treat.
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
README.md (2)

119-119: Nit: improve sentence formatting
Capitalize “Linux”, add a comma and hyphenate “one-line” for clarity. For example:

-To get `linux` binary use this one line command
+To get the `Linux` binary, use this one-line command:

120-122: Enhance download command robustness
The current one-liner is brittle: it lacks HTTP-error checking (-f), relies on grep/awk for JSON parsing, and assumes unzip (and optionally jq) is installed. Consider an optional refactor to improve reliability and readability:

- ```sh
- curl -sL -o subfinder.zip $(curl -sL "https://api.github.com/repos/projectdiscovery/subfinder/releases/latest" | grep "download_url" | grep "linux_$([ "$(uname -m)" = "x86_64" ] && echo "amd64" || uname -m)" | awk -F'"' '{ print $4 }') && unzip -q ./subfinder.zip && rm ./subfinder.zip
- ```
+ ```sh
+ # Map architecture
+ ARCH=$(uname -m); [ "$ARCH" = "x86_64" ] && ARCH=amd64
+ # Fetch download URL via jq (if installed)
+ URL=$(curl -sSL "https://api.github.com/repos/projectdiscovery/subfinder/releases/latest" \
+   | jq -r --arg ARCH "$ARCH" '.assets[] | select(.browser_download_url | contains("linux_\($ARCH)")) | .browser_download_url')
+ # Download and extract with HTTP-error checking
+ curl -sSLf -o subfinder.zip "$URL"
+ unzip -q subfinder.zip && rm subfinder.zip
+ ```

This adds fail-on-error flags, robust JSON parsing, and explicit architecture handling.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b350e9d and d37a8a0.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[uncategorized] ~119-~119: Possible missing comma found.
Context: ...cmd/subfinder@latest To get `linux` binary use this one line commandsh curl -s...

(AI_HYDRA_LEO_MISSING_COMMA)

@dogancanbakir
Copy link
Member

dogancanbakir commented Jun 23, 2025

Thanks for the PR! The command is neat, but we try to keep the README simple and beginner-friendly. For installing and managing PD tools, we recommend using pdtm. If you'd like to contribute alternative installation methods, feel free to open a pull request at projectdiscovery/docs. That'd be a great place to expand on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@green-echooooo @dogancanbakir