read key from env if provided #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
""" WalkthroughA new loop is introduced in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Agent
participant Source
User->>Agent: Call New()
Agent->>Source: Iterate over selected sources
alt Source needs API key
Agent->>Agent: Retrieve API key from ENV
alt API key found
Agent->>Source: AddApiKeys(API_KEY)
end
end
Agent->>Agent: Continue agent creation
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
v2/pkg/passive/sources.go(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Test Builds (ubuntu-latest)
- GitHub Check: Test Builds (windows-latest)
- GitHub Check: Test Builds (macOS-13)
- GitHub Check: release-test
🔇 Additional comments (1)
v2/pkg/passive/sources.go (1)
4-5: LGTM! Import additions are necessary for the new functionality.The added
fmtandosimports support the environment variable reading functionality.
Member
Author
|
fixed test in #1603 |
ehsandeep
approved these changes
Jun 20, 2025
x-stp
pushed a commit
to x-stp/subfinder
that referenced
this pull request
Jun 20, 2025
* read key from env if provided * remove debug code
x-stp
pushed a commit
to x-stp/subfinder
that referenced
this pull request
Jun 20, 2025
* read key from env if provided * remove debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1606
Summary by CodeRabbit