Fix paginations #1603
Merged
Fix paginations #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
""" WalkthroughThe changes update the pagination logic in the Hunter and Quake source modules. Both modules now correctly iterate through paginated API results by dynamically adjusting the page or start parameters in their respective requests, ensuring all available data is retrieved instead of only the first page. Changes
Sequence Diagram(s)sequenceDiagram
participant SubscrapingModule
participant HunterAPI
participant QuakeAPI
SubscrapingModule->>HunterAPI: GET /api/search?domain=...&page=currentPage
loop For each page (Hunter)
HunterAPI-->>SubscrapingModule: Return paginated results
SubscrapingModule->>HunterAPI: GET next page
end
SubscrapingModule->>QuakeAPI: POST /quake_service with start, size params
loop For each page (Quake)
QuakeAPI-->>SubscrapingModule: Return paginated results
SubscrapingModule->>QuakeAPI: POST next page (increment start)
end
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
v2/pkg/subscraping/sources/hunter/hunter.go (1)
59-61: Wrong divisor ⇒ most pages never queried
page_sizeis fixed at 100 in the request, but the page‐count is derived withresponse.Data.Total/1000.
For any data-set larger than 100 records the loop will stop far too early (e.g. 250 items ⇒ 1 page instead of 3).- var pages = 1 + const pageSize = 100 + var pages = 1 ... - pages = int(response.Data.Total/1000) + 1 + pages = (response.Data.Total + pageSize - 1) / pageSize // ceil divisionAlso remember to pass
pageSizeinto the URL:- &page_size=100& + &page_size=%d&Failing to fix this silently drops large portions of the result-set.
Also applies to: 96-97
🧹 Nitpick comments (1)
v2/pkg/subscraping/sources/hunter/hunter.go (1)
59-64: Minor: avoid redundant base64 encoding inside the loop
qbase64depends only on the domain and can be pre-computed once before the loop to save a tiny amount of CPU per page.- for currentPage := 1; currentPage <= pages; currentPage++ { - qbase64 := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf("domain=\"%s\"", domain))) + qbase64 := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf("domain=\"%s\"", domain))) + for currentPage := 1; currentPage <= pages; currentPage++ {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
v2/pkg/subscraping/sources/hunter/hunter.go(1 hunks)v2/pkg/subscraping/sources/quake/quake.go(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
v2/pkg/subscraping/sources/quake/quake.go (2)
v2/pkg/subscraping/types.go (3)
Result(81-86)Error(94-94)Subdomain(93-93)v2/pkg/subscraping/sources/anubis/anubis.go (1)
Source(16-20)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: release-test
🔇 Additional comments (1)
v2/pkg/subscraping/sources/hunter/hunter.go (1)
63-63: Dynamic page parameter – good catchReplacing the hard-coded
1withcurrentPagefinally enables real pagination.
Member
Author
|
lint errs fixed in #1601 |
x-stp
reviewed
Jun 20, 2025
ehsandeep
approved these changes
Jun 20, 2025
x-stp
pushed a commit
to x-stp/subfinder
that referenced
this pull request
Jun 20, 2025
* fix quake pagination * update page param * skip empty * fix test * minor
x-stp
pushed a commit
to x-stp/subfinder
that referenced
this pull request
Jun 20, 2025
* fix quake pagination * update page param * skip empty * fix test * minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1602
Summary by CodeRabbit