这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Mzack9999
Copy link
Member

Mzack9999 added 2 commits May 9, 2018 20:49
- Trivial initial change as mentioned in Issue #34
- WIP: multi domains search fix
wip: to be tested before merging
@Ice3man543
Copy link
Member

@Mzack9999 this type of validation is already performed. I suggest you add a map for multiple outputs, filter subdomains based on domains and add to map and then write to output. You were saying to rewrite passive engine? Are you doing it?

@Ice3man543
Copy link
Member

Also, I already changed dl to dL

@Mzack9999
Copy link
Member Author

Mzack9999 commented May 11, 2018

Sorry about the double flag renaming, I just noticed it now.
About the validation, if I didn't misunderstood, here the issue was about some invalid result being printed in real time as soon as they are discovered, so I introduced this check where it was missing as rapid temporary fix, and later on working on a refactoring of the whole passive section in another PR. Actually the check is done in 3 places:

  • At the end of the whole domain go passive subroutines on the whole discovered subdomains list
  • In some go subroutines on the specific passive source subdomains list
  • On each subdomain in each passive source just after discovery, since the -v flag requires printing the subdomain asap (introduced in this PR to avoid printing out non related subdomains)

@Ice3man543
Copy link
Member

@Mzack9999 We basically need a structure containing keys as domains loaded from list and values as an array []string containing subdomains found or something similar. A complete rewrite by you would be much appreciated and welcomed since the engine has became messy. Also, change the name of enumerate.

@Mzack9999
Copy link
Member Author

Ok @Ice3man543, things are clearer now, I will close then this PR and will open a new one with a rewrite of the passive engine

@Mzack9999 Mzack9999 closed this May 11, 2018
@Mzack9999 Mzack9999 deleted the multiple-domain-list-fix branch May 11, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants