make EnumerateSingleDomain usable as a Go library #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…numerateSingleDomain usable as a Go library
ehsandeep
approved these changes
Apr 17, 2021
Member
ehsandeep
left a comment
There was a problem hiding this comment.
In terms of features, everything looks good to me, it would nice if we can add example use as a library in README so others can make use of this useful change.
@Ice3man543 please confirm.
Ice3man543
approved these changes
Apr 17, 2021
Member
|
Thank you @hachh for making this PR, updated the branch to |
Author
Thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use
EnumerateSingleDomainfrom another program as a Go library, but records are outputted to os.Stdout and cannot be changed without copy/paste the functionSo I made some changes to make
EnumerateSingleDomainoutputs configurable and I moved files creation intoRunEnumeration