Add Rate Limit and User Agent randomization for HTTP requests #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 11, 2021 21:25
HTTP User-Agent header randomization. Adds -unsafe flag to send requests with default User-Agent header.
added 4 commits
August 11, 2021 21:42
HTTP User-Agent should be randomized by default since subfinder uses third party apis
ehsandeep
approved these changes
Aug 12, 2021
Mzack9999
approved these changes
Aug 16, 2021
Member
|
thank you @taythebot for adding both features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added user agent randomization(#447) and rate limiting for HTTP requests (#362).
User agent randomization is implemented using the uarand library. It is enabled by default since Subfinder exclusively uses third party APIs.
Rate limit is implemented using the ratelimit library and the flag is
rate-limit. The default value for the flag is 0, which creates an "unlimited" rate limit instance.