这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Mzack9999
Copy link
Member

Fixes #39

@Ice3man543
Copy link
Member

@Mzack9999 This needs to be done for every passive source we have. Don't worry about this, i will do it. You can focus on passive rewrite. The output of passive module also looks cluttered and most of recursion and Multiple domains doesn't work. 😢

@Ice3man543 Ice3man543 self-assigned this May 12, 2018
@Mzack9999
Copy link
Member Author

@Ice3man543 This was a fast "fix" in order to give at least the reason of failure. I suppose it's not necessary in others, I debugged the issue and it happens just in this module. I plan to change also every passive source to be totally async and reduce the usage of long living objects to minimum and meanwhile I will also fix these not working modules, I can't allocate a lot of time right now, so it will take some time

@Ice3man543
Copy link
Member

@Mzack9999 Awesome work. Really appreciate you contributing to this tool. No need to hurry. Just, create a branch and make one source asynchronous. Others I can do following what you do to one. What are those not working modules?

@Mzack9999
Copy link
Member Author

I saw this one, and there was another one that produced weird results (probably an issue related to regex or parsing), later on filtered out by the final validation. I said generically "not working modules" to mean that I will try to fix these issues along the way if it happens I work on such modules

@Ice3man543 Ice3man543 merged commit e769c95 into master May 22, 2018
@codingo codingo deleted the unwanted-char-fix branch May 22, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants