fix(MultiSelect): prevent toggling disabled option when using toggle all #7882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #7881
Context
This PR intends to fix disabled options being updated when using the "toggle all" checkbox from the MultiSelect component.
Proposed solution
When
onToggleAllevent occurs, we should always include the disabled options when updating the modelValue, either when selecting all or unselecting all.Testing
I've added some unit tests using the existing code structure as much as possible ❤️
Additional notes
I noticed there is no documentation about disabled options in the current MultiSelect docs, I'd be happy to add some in the Disabled section if needed.